Basketball shorts are great for comfort but terrible for phones, wallets and keys. Let's hear it for pockets.
Cargo pockets down low on the side of your legs with Velcro are my favorites, or zippers. Not buttons; who has time to button a pocket? Snaps never work for long.
Back pockets are good, and deep side pockets are the best.
Mostly, the more the better.